
		7) UUCICO throws away data on line errors

From: teklabs!zehntel!sytek!gi!arizona!utah-cs!lepreau
Date: Thu Oct  7 17:30:45 1982
Subject: Re: UUCP truncates files
Newsgroups: net.news.config
References: cntrl.c,pk1.c

Date: 28 Sep 82 2:31:50-PDT (Tue)
To: Unix-Wizards at SRI-UNIX
From: menlo70!sri-unix!fortune!Dave-Yost (Dave-Yost ) at Ucb-C70
Subject: UUCP BUG FIX -- uucico throws away data

Uucp bug:
A sends file to B,
A is master.
A logs the following:
  day randvax (9/9-13:58-7031) REQUEST (S D.hollywoX0367 X.hollywoX0367 day)
  day randvax (9/9-13:59-7031) BAD READ (expected 'C' got FAIL)
The file is not successfully transferred.
A deletes the D. file (WRONG).
Next time the connection is made:
  day randvax (9/9-14:26-7227) REQUEST (S D.hollywoX0367 X.hollywoX0367 day)
  day randvax (9/9-14:26-7227) FAILED (CAN'T READ DATA)
Et voila!  The file transfer never happens.

This problem has happened to me several times in one week!
(All because of GTE, of course.)

Fix: in cntrl.c, change
			unlinkdf(W_DFILE);
			RMESG(RQSTCMPT, msg);
			goto process;
to
			RMESG(RQSTCMPT, msg);
			unlinkdf(W_DFILE);
			goto process;

While you're at it, I recommend the following change in pk1.c:

  #define GETRIES 10      /* 5 in 4.1bsd -- d yost */

I watched uucico give up after 5 retries many, many times.
This got old, so I increased it to 10, and on the very next
connection I saw it pick up the conversation again after about
9 retries.

--dave yost

